> On Jan 11, 2018, at 3:07 PM, Ben Pfaff <[email protected]> wrote: > > On Thu, Jan 11, 2018 at 10:15:12PM +0000, Stokes, Ian wrote: >>> Until now, when "sparse" reported a warning, it didn't fail the build for >>> that file, even when the project was configured with --enable-Werror, >>> which made it easy to miss warnings. This commit fixes the problem. >>> >>> Reported-by: "Stokes, Ian" <[email protected]> >>> Signed-off-by: Ben Pfaff <[email protected]> >> >> Thanks for the patch Ben, works as expected now. >> >> Acked-by: Ian Stokes <[email protected]> >> Tested-by: Ian Stokes <[email protected]> > > Thanks for review and testing. I applied this to master.
This doesn't seem to break the build as I would have expected: -=-=-=-=-=-=-=-=- libtool: compile: env REAL_CC=gcc "CHECK=sparse -Wsparse-error -I ./include/sparse -m64 -I /usr/local/include -I /usr/include/x86_64-linux-gnu " cgcc -target=x86_64 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool -Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare -Werror -Werror -g -O2 -MT lib/odp-util.lo -MD -MP -MF lib/.deps/odp-util.Tpo -c lib/odp-util.c -o lib/odp-util.o make[3]: 'distfiles' is up to date. make[3]: Leaving directory '/home/jpettit/src/openvswitch/datapath' lib/odp-util.c:1250:39: warning: incorrect type in argument 1 (different base types) lib/odp-util.c:1250:39: expected unsigned long [unsigned] [usertype] <noident> lib/odp-util.c:1250:39: got restricted ovs_be64 [addressable] [usertype] rule_cookie -=-=-=-=-=-=-=-=- I'm using sparse 0.5.0, which I think is the newest. Any thoughts? Thanks, --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
