> -----Original Message----- > From: Ilya Maximets [mailto:[email protected]] > Sent: Friday, 12 January, 2018 16:57 > To: Jan Scheurich <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; Darrell Ball > <[email protected]>; Aaron Conole <[email protected]> > Subject: Re: [PATCH v9 1/2] dpif-netdev: Refactor PMD performance into > dpif-netdev-perf > > > /* The Netlink encoding of datapath flow keys cannot express > > @@ -5137,6 +5066,9 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd, > > ovs_mutex_unlock(&pmd->flow_mutex); > > emc_probabilistic_insert(pmd, key, netdev_flow); > > } > > + /* Only error ENOSPC can reach here. We process the packet but do not > > + * install a datapath flow. Treat as successful. */ > > + return 0; > > This change looks strange. You're returning 0 (successful) here, but patch #2 > removes the comment and returns error instead. > IMHO, we need to choose one of these solutions and implement it in patch #1.
That was not my intention. It is a leftover. Will fix in next version. > I'm not sure what was the result of discussion with Aaron and Darrell about > this? > What should we return? We agreed to not agree and I therefore proposed to keep the current implementation to count upcalls that processed the packet but failed to install a datapath flow in because of ENOSPC and return "error" here. It can be addressed in a new patch if so wanted. BR, Jan _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
