> -----Original Message----- > From: Ilya Maximets [mailto:[email protected]] > Sent: Wednesday, 17 January, 2018 08:50 > To: Jan Scheurich <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected] > Subject: Re: [PATCH v7 0/3] dpif-netdev: Detailed PMD performance metrics and > supervision > > Not a full review, just a note about man pages. > Current version of netdev-dpif-unixctl.man doesn't scale and looks bad > with different terminal widths. I refactored it to look more like a man > page. See the incremental patch below.
Thank you, that is a great help. As you could tell, I have never prepared a man page before... > > What changed: > * Dash lists re-formatted using "\(em" tags. > * Numbered list re-formatted using ".IP N.". > * Command option lists re-formatted using usual paragraphs with indentation. > * Output example indented as recommended by man pages guidelines. > * Removed extra spaces in "pmd-perf-log-set" command header. > * 'pmd-stats-clear' moved closer to 'pmd-stats-show' for integrity. > > One more thing: > Can we rename "netdev-dpif-unixctl.man" to "dpif-netdev-unixctl.man" ? > I don't understand why it named so. Will do so. I just adapted the name from existing netdev-dpdk-unixctl.man without too much thinking. Regards, Jan _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
