On Wed, Jan 17, 2018 at 12:43:08PM +0000, Vishal Deep Ajmera wrote: > Hi Flavio,
Hi Vishal, > I was testing your patch and comparing the stats of tap port for both > ovs-master > and your patch. The drop stats are now matching with master. Thanks for doing that work, I appreciate it! > However I still see one more difference, in earlier case the "tx_packets" > were > also incremented along with "tx_dropped" when the tap port is DOWN. But with > your patch "tx_packets" does not increment. Though I believe the new stats > seem > to be correct. Does it need to be documented ? I wonder how to interpret that combination because either the packet is transmitted or dropped, so I agree that now it seems to be correct. You mean add more details to NEWS file explaining that change? > Otherwise the patch look ok to me. > > Tested-by: Vishal Deep Ajmera <[email protected]> Thanks! -- Flavio _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
