On Sun, Jan 14, 2018 at 08:26:47PM +0200, Alin Gabriel Serdean wrote: > The test: > 1948. ovsdb-client.at:15: testing ovsdb-client backup and restore > fails on Windows with: > --- /dev/null 2018-01-14 20:09:57 +0200 > +++ /c/_2018/january/14/ovs/tests/testsuite.dir/at-groups/1948/stderr > @@ -0,0 +1,3 @@ > +ovsdb-server: ovsdb error: backup: unexpected file format > +ovsdb-server: Failed to read from child (The pipe has been ended. > +) > ./ovsdb-client.at:111: exit code was 1, expected 0 > > The root cause is that when redirecting output defaults to the Windows line > endings(CRLF): > $ file db > db: ASCII text, with very long lines > $ file backup > backup: ASCII text, with very long lines, with CRLF line terminators > > Add a `dos2unix` command to convert to the line endings expected by > ovsdb-server. > > Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org>
Thank you for the fix. Hmm, maybe this is a bug in "ovsdb-client backup". Maybe it should do something like: #ifdef _WIN32 fflush(stdout); _setmode(STDOUT_FILENO, _O_BINARY); #endif and then the test wouldn't have to change at all? What do you think? I don't know whether anything similar is needed for stdin for "ovsdb-client restore". _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev