> -----Original Message-----
> From: Ilya Maximets [mailto:[email protected]]
> Sent: Tuesday, January 23, 2018 7:52 AM
> To: [email protected]
> Cc: Heetae Ahn <[email protected]>; Ben Pfaff <[email protected]>;
> Stokes, Ian <[email protected]>; Ilya Maximets
> <[email protected]>; Weglicki, MichalX <[email protected]>
> Subject: [PATCH] netdev-dpdk: Fix xstats leak on port destruction.
> 

Thanks Ilya, applied to DPDK_MERGE and DPDK_MERGE_2_9.

Regards
Ian

> CC: Michal Weglicki <[email protected]>
> Fixes: 971f4b394c6e ("netdev: Custom statistics.")
> Signed-off-by: Ilya Maximets <[email protected]>
> ---
>  lib/netdev-dpdk.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index bdce304..50a94d1
> 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -452,6 +452,8 @@ struct netdev_rxq_dpdk {  static void
> netdev_dpdk_destruct(struct netdev *netdev);  static void
> netdev_dpdk_vhost_destruct(struct netdev *netdev);
> 
> +static void netdev_dpdk_clear_xstats(struct netdev_dpdk *dev);
> +
>  int netdev_dpdk_get_vid(const struct netdev_dpdk *dev);
> 
>  struct ingress_policer *
> @@ -1104,6 +1106,7 @@ netdev_dpdk_destruct(struct netdev *netdev)
>          }
>      }
> 
> +    netdev_dpdk_clear_xstats(dev);
>      free(dev->devargs);
>      common_destruct(dev);
> 
> @@ -1169,7 +1172,7 @@ netdev_dpdk_dealloc(struct netdev *netdev)  }
> 
>  static void
> -netdev_dpdk_clear_xstats(struct netdev_dpdk *dev) OVS_REQUIRES(dev-
> >mutex)
> +netdev_dpdk_clear_xstats(struct netdev_dpdk *dev)
>  {
>      /* If statistics are already allocated, we have to
>       * reconfigure, as port_id could have been changed. */
> --
> 2.7.4

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to