On Tue, Jan 09, 2018 at 07:54:31PM +0100, Zoltan Balogh wrote: > By avoiding Tx recirculation and embedding tnl_push action within clone, > the tunnel metadata is not propagated when sflow is read. Unless clone > action is handled in the dpif_sflow_read_actions() function as well. > This commit resolves this issue. > > In addition, some sflow data needs to be stored and restored in > ofproto-dpif-xlate when native_tunnel_output() is invoked. Otherwise the > output action of underlay bridge is getting counted too when sFlow is set > on the overlay bridge. > Both bugs are connected to sflows and were introduced by the commit in > the "Fixes:" tag below. > > Signed-off-by: Zoltan Balogh <[email protected]> > CC: Sugesh Chandran <[email protected]> > Fixes: 7c12dfc527a5 ("tunneling: Avoid datapath-recirc by combining > recirc actions at xlate.")
Thanks a lot for the fix. It took me a while to properly understand the commit message, so I rewrote it a bit: commit 283d866294b128610acde63027283ce738d97b6c Author: Zoltan Balogh <[email protected]> Date: Tue Jan 9 19:54:31 2018 +0100 ofproto-dpif-sflow: Recursively examine actions inside clone. Until now, dpif_sflow_read_actions() has ignored actions inside clone. This means that sflow missed tnl_push actions inside clone, which OVS now uses to avoid tx recirculation. This commit fixes the problem by making dpif_sflow_read_actions() recursively process actions inside clone. In addition, some sflow data needs to be stored and restored in ofproto-dpif-xlate when native_tunnel_output() is invoked. Otherwise the output action of underlay bridge is getting counted too when sFlow is set on the overlay bridge. Both bugs are connected to sflows and were introduced by the commit in the "Fixes:" tag below. Signed-off-by: Zoltan Balogh <[email protected]> CC: Sugesh Chandran <[email protected]> Fixes: 7c12dfc527a5 ("tunneling: Avoid datapath-recirc by combining recirc actions at xlate.") Signed-off-by: Ben Pfaff <[email protected]> With those changes, I applied this to master and branch-2.9. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
