On 24/01/18 15:50, Róbert Mulik wrote:
Hi Eelco and Ian,
Thank you for the comments. I uploaded patch v3 based on them.
I'll try to look at this asap, but I'm on a trip the rest of this week,
and next.
There is only one comment I have problem with:
"This function is not catching this sequence:
ovs-vsctl set interface dpdk0 options:dpdk-lsc-interrupt=true
ovs-vsctl remove interface dpdk0 options dpdk-lsc-interrupt"
I verified set and remove before uploading the patch. They worked fine. As I
see, when the options part of an interface is changed, function
bridge_delete_or_reconfigure_ports (in file vswitchd/bridge.c) is called and
the interfaces will be reconfigured based on the new options by this part of
the code:
if (strcmp(ofproto_port.type, iface->netdev_type)
|| netdev_set_config(iface->netdev, &iface->cfg->options, NULL)) {
/* The interface is the wrong type or can't be configured.
* Delete it. */
goto delete;
}
I tried this in my setup with your patch applied, and a reconfigure was
not triggered. Will try it again when reviewing your V3.
//Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
