> On Jan 25, 2018, at 12:36 PM, Aaron Conole <acon...@redhat.com> wrote: > > Because more voices of support are better - I am in favor of this > change. > > I agree with the sentiment that checkpatch is meant to help bring things > to light that humans sometimes glaze over (we all develop our own way of > 'reading' code - for me I just don't *see* whitespace anymore, so > checkpatch helps me self enforce it). I don't think I'd ever trust a > machine, even one as snazzy as checkpatch, with true veto power over a > change. In that vein, this helps draw the eye to "hey there's really > something incomplete here - perhaps it is worth taking a closer look." > > Especially since I have been known to leave things behind - and having > the checkpatch hook catch it for me early is better. > > All that long winded response to simply: > > Acked-by: Aaron Conole <acon...@redhat.com>
Thanks! I pushed this to master. > On a side note - I was really happy to see that the in-comment tracking > worked for most of the cases I tried. The only one that didn't catch > is: > > /* > XXX : something here > */ > > but I don't think it's worth trying to solve that :) Thanks. The patch that initiated it had a couple variations, which made me work harder on it than I probably would have. I agree that it has some room for improvement, though. :-) --Justin _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
