On Tue, Oct 17, 2017 at 04:29:40PM +0200, Frode Nordahl wrote: > Currently, on installation or upgrade the openvswitch-switch deb package > will in some circumstances modify a pre-existing > /etc/default/openvswitch-switch configuration file. > > This does not play well with modeling and configuration management tools > and may lead to unnecessary restarts of the openvswitch-switch service > after the initial restart done as part of the package upgrade. As > restarting the openvswitch-switch affects the datapath this is > something we should try to avoid. > > I also believe the current behaviour to be in conflict with best practices > set out in the config files section of the > [Debian Policy](https://www.debian.org/doc/debian-policy/#s-config-files). > > This commit addresses this by removing the part of the postinst script > that attempts to append missing documentation parts of the template > and leaves the installed defaults file alone when it exists. > > Signed-off-by: Frode Nordahl <[email protected]> > Reported-at: https://github.com/openvswitch/ovs-issues/issues/137
Thanks, this code was added in 2009 with the following commit. It's clearly past its "sell-by" date, so I applied your patch to OVS master. commit 0aaa379d99f4fb48eb34b1ea5858b0954a5f8c8d Author: Ben Pfaff <[email protected]> Date: Tue Jan 20 13:33:44 2009 -0800 Debian packaging: Add several new settings to /etc/default/openflow-switch. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
