>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>boun...@openvswitch.org] On Behalf Of Ian Stokes
>Sent: Tuesday, January 30, 2018 10:07 AM
>To: d...@openvswitch.org
>Subject: [ovs-dev] [PATCH branch-2.7] docs: Use DPDK 16.11.4 stable release.
>
>Modify docs and travis linux build script to use DPDK 16.11.4 stable
>branch to benefit from most recent bug fixes.

Hey Ian,

LGTM on the whole.

If I had to be super-critical, I'd probably change the patch subject line from 
'docs:' to 'dpdk:' or something along those lines, since the included changes 
impact travis scripts, as well as documentation. Also, one minor comment below. 
There's no need to spin a new version; once these changes are addressed, feel 
free to add my Ack when pushing the patch.

Cheers,
Mark

>
>There are no new features introduced in the DPDK release, only back
>ported bug fixes. For completeness these bug fixes have been
>documented under the 16.11.4 section in the link below.
>
>http://dpdk.org/doc/guides-16.11/rel_notes/release_16_11.html

Direct link to the 16.11.4 section: 
http://dpdk.org/doc/guides-16.11/rel_notes/release_16_11.html#id4 

>
>Signed-off-by: Ian Stokes <ian.sto...@intel.com>
>---
> .travis/linux-build.sh                   | 2 +-
> Documentation/faq/releases.rst           | 2 +-
> Documentation/intro/install/dpdk.rst     | 6 +++---
> Documentation/topics/dpdk/vhost-user.rst | 8 ++++----
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>index 67f3ec2..088f20f 100755
>--- a/.travis/linux-build.sh
>+++ b/.travis/linux-build.sh
>@@ -80,7 +80,7 @@ fi
>
> if [ "$DPDK" ]; then
>     if [ -z "$DPDK_VER" ]; then
>-        DPDK_VER="16.11.3"
>+        DPDK_VER="16.11.4"
>     fi
>     install_dpdk $DPDK_VER
>     if [ "$CC" = "clang" ]; then
>diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
>index fa983cb..c60d0ad 100644
>--- a/Documentation/faq/releases.rst
>+++ b/Documentation/faq/releases.rst
>@@ -160,7 +160,7 @@ Q: What DPDK version does each Open vSwitch release work
>with?
>     2.4.x        2.0
>     2.5.x        2.2
>     2.6.x        16.07.2
>-    2.7.x        16.11.3
>+    2.7.x        16.11.4
>     ============ =======
>
> Q: I get an error like this when I configure Open vSwitch::
>diff --git a/Documentation/intro/install/dpdk.rst
>b/Documentation/intro/install/dpdk.rst
>index 55d8bd1..4ee93f2 100644
>--- a/Documentation/intro/install/dpdk.rst
>+++ b/Documentation/intro/install/dpdk.rst
>@@ -64,9 +64,9 @@ Install DPDK
> #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>
>        $ cd /usr/src/
>-       $ wget http://fast.dpdk.org/rel/dpdk-16.11.3.tar.xz
>-       $ tar xf dpdk-16.11.3.tar.xz
>-       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.3
>+       $ wget http://fast.dpdk.org/rel/dpdk-16.11.4.tar.xz
>+       $ tar xf dpdk-16.11.4.tar.xz
>+       $ export DPDK_DIR=/usr/src/dpdk-stable-16.11.4
>        $ cd $DPDK_DIR
>
> #. (Optional) Configure DPDK as a shared library
>diff --git a/Documentation/topics/dpdk/vhost-user.rst
>b/Documentation/topics/dpdk/vhost-user.rst
>index 2150809..b75c9dc 100644
>--- a/Documentation/topics/dpdk/vhost-user.rst
>+++ b/Documentation/topics/dpdk/vhost-user.rst
>@@ -278,9 +278,9 @@ To begin, instantiate a guest as described in
>:ref:`dpdk-vhost-user` or
> DPDK sources to VM and build DPDK::
>
>     $ cd /root/dpdk/
>-    $ wget http://fast.dpdk.org/rel/dpdk-16.11.3.tar.xz
>-    $ tar xf dpdk-16.11.3.tar.xz
>-    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.3
>+    $ wget http://fast.dpdk.org/rel/dpdk-16.11.4.tar.xz
>+    $ tar xf dpdk-16.11.4.tar.xz
>+    $ export DPDK_DIR=/root/dpdk/dpdk-stable-16.11.4
>     $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>     $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>     $ cd $DPDK_DIR
>@@ -364,7 +364,7 @@ Sample XML
>         </disk>
>         <disk type='dir' device='disk'>
>           <driver name='qemu' type='fat'/>
>-          <source dir='/usr/src/dpdk-stable-16.11.3'/>
>+          <source dir='/usr/src/dpdk-stable-16.11.4'/>
>           <target dev='vdb' bus='virtio'/>
>           <readonly/>
>         </disk>
>--
>2.7.5
>
>_______________________________________________
>dev mailing list
>d...@openvswitch.org
>https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to