On 6 February 2018 at 06:44, Matteo Croce <[email protected]> wrote:
> Documentation for both n-handler-threads and n-revalidator-threads was
> wrong, the spawned threads are per port instead of per datapath.
>
> Update the docs according to vswitchd/ovs-vswitchd.8.in and code behaviour.
>
> Signed-off-by: Matteo Croce <[email protected]>
> ---
Hi Matteo,
The only reference to handler or revalidator threads in
vswitchd/ovs-vswitchd.8.in is documenting how many file descriptors
are opened, which is dependent upon 'n-handler-threads'. This
documentation in vswitch.xml, on the other hand, describes the number
of threads are spawned, not the number of file descriptors (which is
correct):
$ grep -C 4 -e handler -e revalidator vswitchd/ovs-vswitchd.8.in
\fBovs\-vswitchd\fR started through \fBovs\-ctl\fR(8) provides a limit of 65535
file descriptors. The limits on the number of bridges and ports is decided by
the availability of file descriptors. With the Linux kernel datapath, creation
of a single bridge consumes three file descriptors and adding a port consumes
"n-handler-threads" file descriptors per bridge port. Performance will degrade
beyond 1,024 ports per bridge due to fixed hash table sizing. Other platforms
may have different limitations.
.
.IP \(bu
joe@dellingr ~/git/ovs $ ovs-vsctl get Open_vSwitch . other-config
{n-handler-threads="1", n-revalidator-threads="1"}
joe@dellingr ~/git/ovs $ ovs-vsctl show
fa5dee31-6e87-4b53-a4ac-84b2849e4fe2
Bridge "br0"
Port "p1"
Interface "p1"
type: dummy
Port "p0"
Interface "p0"
type: dummy
Port "dummy0"
Interface "dummy0"
Port "br0"
Interface "br0"
type: internal
joe@dellingr ~/git/ovs $ ps H -o 'tid comm' $(pidof ovs-vswitchd)
TID COMMAND
16960 ovs-vswitchd
17325 ct_clean1
17326 urcu2
17937 handler15
17938 revalidator16
Above, you can see that I set these two settings to 1, and added a
bunch of ports to OVS, then observed that there is still just one of
each of the threads. Therefore the setting is not per-port.
Cheers,
Joe
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
