Thanks for the review! I applied this to master and backported as far as branch-2.5.
On Fri, Feb 16, 2018 at 01:43:20AM -0800, Yifeng Sun wrote: > ofputil_pull_bands may change bands->data. Thanks for the fix. > > Reviewed-by: Yifeng Sun<[email protected]> > > > On Wed, Feb 14, 2018 at 2:36 PM, Ben Pfaff <[email protected]> wrote: > > > Found by libfuzzer-ngram. > > > > Reported-by: Bhargava Shastry <[email protected]> > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > lib/ofp-meter.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/ofp-meter.c b/lib/ofp-meter.c > > index 204f035ec290..4f77f508d396 100644 > > --- a/lib/ofp-meter.c > > +++ b/lib/ofp-meter.c > > @@ -98,12 +98,12 @@ ofputil_decode_meter_mod(const struct ofp_header *oh, > > mm->meter.flags & OFPMF13_PKTPS) { > > return OFPERR_OFPMMFC_BAD_FLAGS; > > } > > - mm->meter.bands = bands->data; > > > > error = ofputil_pull_bands(&b, b.size, &mm->meter.n_bands, bands); > > if (error) { > > return error; > > } > > + mm->meter.bands = bands->data; > > } > > return 0; > > } > > -- > > 2.16.1 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
