Hi Ben and Jan,
Much Thanks to both of your for you valuable inputs, we've addressed almost all
the modifications you both mentioned.
Consolidating all the Inputs below are the quick updates and clarifications
required.
>> JAN and BEN Comment - 1) ovs-ofctl dump-flows" should provide similar
>> results for all versions of OpenFlow.
In OpenFlow 1.5, that means that it should use a "flow desc" requestrather than
a "flow stats" request.
We've modified our patch as per the above comment i.e as per OF 1.5+ the
OFPMP_FLOW_DESC request is used instead of the earlier OFPMP_FLOW.
>> JAN Comment - 2) I suggest to introduce a new command or add an option to
>> dump-flows to force use of this particular MP message. The output would be
>> limited to flow match and stats in that case.
As per Jan's suggestion we've added an option to the dump-flows for the OF 1.5
which will give an output which will show only flow stats for the requested OXS
fields.
Like below:
dump-flows switch [flows]
By default, ovs-ofctl prints flow entries in the same order that
the switch sends them along with the flow description flags
Use --oxs-stats[=field]
Which displays the output with the requested OXS field/fields
(packet-count, byte-count etc.,)
>> Jan Comment - 3 ) The new command to dump aggregate flow stats is of course
>> a welcome addition.
This requirement will also get fulfilled with the addition of --oxs-stats
option to the existing dump-aggregate command.
Like Below
dump-aggregate switch [flows]
Use --oxs-stats[=field]
Prints to the console aggregate statistics for flows with the
requested OXS field/fields (packet-count, byte-count etc.,)
Jan and Ben we requesting you both kindly provide your valuable inputs with
respect new enhancement i.e adding --oxs-stats option to the existing
commands.
If everything mentioned above is fine then we will share the updated patch soon.
Thanks & Regards
Satya Valli
Tata Consultancy Services
Mailto: [email protected]
Website: http://www.tcs.com
____________________________________________
Experience certainty. IT Services
Business Solutions
Consulting
____________________________________________
-----Ben Pfaff <[email protected]> wrote: -----
To: SatyaValli <[email protected]>
From: Ben Pfaff <[email protected]>
Date: 02/09/2018 11:23PM
Cc: [email protected], Manasa Cherukupally <[email protected]>,
Surya Muttamsetty <[email protected]>, Pavani Panthagada
<[email protected]>, Satya Valli <[email protected]>, Lavanya Harivelam
<[email protected]>
Subject: Re: [ovs-dev] [PATCH v3] OF1.5/EXT-334 OXS/Extensible Flow Entry
Statistics Support
On Tue, Feb 06, 2018 at 05:17:19PM +0530, SatyaValli wrote:
> From: SatyaValli <[email protected]>
>
> This Patch provides implementation Existing flow entry statistics are
> redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> displaying the arbitrary flow stats.The existing Flow Stats were renamed
> as Flow Description.
Thanks for the updated patch.
After a small amount of reading, I agree with Jan Scheurich. "ovs-ofctl
dump-flows" should provide similar results for all versions of OpenFlow.
In OpenFlow 1.5, that means that it should use a "flow desc" request
rather than a "flow stats" request.
Thanks,
Ben.
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information contained in this e-mail message
and/or attachments to it are strictly prohibited. If
you have received this communication in error,
please notify us by reply e-mail or telephone and
immediately and permanently delete the message
and any attachments. Thank you
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
