Adding Ben to thread also. The footprint isn't that bad compares to the MSI images: alin@DESKTOP-IUDEFLM /c/_2018/march/temp/ovs/windows $ ls -lh ovs-windows-installer/images/ total 582K -rw-r--r-- 1 alin Administrators 132K Mar 6 20:00 bannrbmp.bmp -rw-r--r-- 1 alin Administrators 450K Mar 6 20:00 dlgbmp.bmp
alin@DESKTOP-IUDEFLM /c/_2018/march/temp/ovs/windows $ ls -lh pthreads-w32-2-9-1-release.tar.gz -rw-r--r-- 1 alin Administrators 361K Mar 6 20:37 pthreads-w32-2-9-1-release.tar.gz It makes it easier for people which are building on systems that don't have an internet connections. Another idea would be to have `--with-pthread-tar=` and point it to the tarball. Which one do you prefer? Thanks, Alin. -----Mesaj original----- De la: [email protected] <[email protected]> În numele Shashank Ram Trimis: Tuesday, March 6, 2018 8:17 PM Către: Alin Gabriel Serdean <[email protected]> Cc: [email protected] Subiect: Re: [ovs-dev] [PATCH] [RFC] build-windows: Add pthread to windows build Hi Alin, please lets not checkin a binary file into the repo. It will make the repo size bigger and some git operations slower. Also it will be a pain to erase it from the history if it needs to be removed. Thanks, Shashank On Mon, Mar 5, 2018 at 4:40 AM, Alin Gabriel Serdean <[email protected]> wrote: > Until know we asked users to download a precompiled library of `pthreads` > as > part of the build chain. > > A big problem with this approach is that the precompiled version of > pthreads > is built using VS2010 and we must redistribute that runtime to install > targets > as well. > > The library seems to be abandoned and no longer maintained. I tried to > email > the authors several times and unfortunately, I haven’t received a reply. > In the end we might end up maintaining the project under the folder > `windows`. > > For now, however we just add the source tarball of the pthread library to > the > `windows` folder. We simplify the process of installing and building by > compiling pthread library shipped in the `windows` folder during the build > step. > We still allow `--with-pthread=` argument during configure step. If that > argument is not specified we fall back to the shipped tarball. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > --- > Makefile.am | 11 +++++++++++ > m4/openvswitch.m4 | 17 ++++++++++++++++- > windows/.gitignore | 3 +++ > windows/automake.mk | 3 ++- > windows/pthreads-w32-2-9-1-release.tar.gz | Bin 0 -> 369537 bytes > 5 files changed, 32 insertions(+), 2 deletions(-) > create mode 100644 windows/pthreads-w32-2-9-1-release.tar.gz > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
