> -----Mesaj original----- > De la: [email protected] <ovs-dev- > [email protected]> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:20 PM > Către: Alin Gabriel Serdean <[email protected]> > Cc: [email protected] > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging > > On Tue, Mar 06, 2018 at 01:17:12PM +0200, Alin Gabriel Serdean wrote: > > The test: > > `1827. ovsdb-server.at:490: testing SSL db: implementation ...` is > > hanging on Windows because the returned in the case the client failed > > to connect is "Unknown error" vs the normal "Protocol error". > > > > Update the test to accommodate for this. > > > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > > Thanks for finding and fixing the error. > > I think that there is an underlying problem here: the code is bad at error > handling in general. It's supposed to kill the ovsdb-server if anything > fails, > but it didn't do it right: it killed $(cat pid) but the pidfile is actually > in ovsdb- > server.pid. This meant that the issue showed up as a hang instead of a test > failure, which seems bad. > > Also, I'm kind of inclined to just disregard the particular error message. It > might save time later. (I guess there's a risk that the connection fails > happens for some other reason that should fail the test > though.) > > Anyway, I sent a pair of patches that implement my suggestions: > https://patchwork.ozlabs.org/patch/882796/ > https://patchwork.ozlabs.org/patch/882798/ > > What are your thoughts? > > Thanks, > > Ben. [Alin Serdean] I'm dropping this change and acking yours. They are much cleaner and better 😊.
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
