Thanks for the quick review. I removed the import and changed a bit the message.
Applied on master. Alin. > -----Mesaj original----- > De la: [email protected] <ovs-dev- > [email protected]> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:07 PM > Către: Alin Gabriel Serdean <[email protected]> > Cc: [email protected] > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Make flow extractor work on > Windows > > Applying this commit adds a file named > "c/_2018/march/06/ovs/tests/testsuite.dir/at-groups/42/stderr" to the > repo! I think that the failure needs to be indented a bit to un-confuse "git > am". > > When I fix that up, I get the following failure from flake8: > ../tests/flowgen.py:17:1: F401 'os' imported but unused > > Assuming you fix up those two little things: > Acked-by: Ben Pfaff <[email protected]> > > Thanks! > > On Tue, Mar 06, 2018 at 05:23:56PM +0200, Alin Gabriel Serdean wrote: > > 42. library.at:3: testing flow extractor ... > > ./library.at:4: $PYTHON $srcdir/flowgen.py >/dev/null 3>flows 4>pcap > > --- /dev/null 2018-03-06 15:59:49 +0200 > > +++ /c/_2018/march/06/ovs/tests/testsuite.dir/at-groups/42/stderr > 2018-03-06 15:59:49 +0200 > > @@ -0,0 +1,4 @@ > > +Traceback (most recent call last): > > + File "../.././flowgen.py", line 204, in <module> > > + flows = os.fdopen(3, 'wb') > > +OSError: [Errno 9] Bad file descriptor > > ./library.at:4: exit code was 1, expected 0 42. library.at:3: FAILED > > (library.at:4) > > > > Unfortunately 3/4/5/.. FDs don't work on Windows. Switch to a filename > > open instead of opening the FDs. > > > > Signed-off-by: Alin Gabriel Serdean <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
