On Fri, Mar 2, 2018 at 5:01 AM, Numan Siddique <nusid...@redhat.com
<mailto:nusid...@redhat.com>> wrote:
On Feb 28, 2018 6:12 PM, "Guru Shetty" <g...@ovn.org
<mailto:g...@ovn.org>> wrote:
This is a little more complicated for a quick review. I think
it will need
a round from me to understand the implications for gateway
routers and one
round from Numan (or someone from openstack) that use
distributed gateway
routers.
Ack. I will take a look at the patch as well.
Thanks
Numan
On 14 February 2018 at 16:42, Ben Pfaff <b...@ovn.org
<mailto:b...@ovn.org>> wrote:
> Hi Guru. Are you willing to take a look at this patch?
>
> Thanks,
>
> Ben.
>
> On Fri, Feb 09, 2018 at 03:34:55PM +0800, Guoshuai Li wrote:
> > The main application scenario of this patch is that the
user flow wants
> to
> > different destination addresses through different external
networks.
> > This scenario requires a distributed route to be
associated with
> > multiple external network logical switches.
> >
> > Change l3dgw_port to l3dgw_ports in ovn_datapath,and change
> > l3redirect_port to ovn_port. Then in a distributed router,
the NAT
> > logical flow table is generated based on the external IP
lookup
> > distributed router port, otherwise not generated. And LB
is the same.
> >
> > When the destination address of the packet is an external
IP of the NAT
> rule,
> > and the ingress port is not a gateway, it is necessary to
route to the
> actual
> > outgoing port.
> >
> > Signed-off-by: Guoshuai Li <l...@dtdream.com
<mailto:l...@dtdream.com>>
Hi Guoshuai Li,
I am getting the below compilation errors with "-Werror" option
**********
../ovn/northd/ovn-northd.c: In function ‘build_lrouter_flows’:
../ovn/northd/ovn-northd.c:5394:29: error: declaration of ‘i’ shadows
a previous local [-Werror=shadow]
for (size_t i = 0; i < od->n_l3dgw_ports; i++) {
^
../ovn/northd/ovn-northd.c:5139:18: note: shadowed declaration is here
for (int i = 0; i < od->nbr->n_nat; i++) {
^
../ovn/northd/ovn-northd.c:5395:38: error: declaration of ‘l3dgw_port’
shadows a previous local [-Werror=shadow]
struct ovn_port *l3dgw_port = od->l3dgw_ports[i];
^~~~~~~~~~
../ovn/northd/ovn-northd.c:5197:30: note: shadowed declaration is here
struct ovn_port *l3dgw_port = find_l3dgw_port(od,
^~~~~~~~~~
../ovn/northd/ovn-northd.c:5413:29: error: declaration of ‘i’ shadows
a previous local [-Werror=shadow]
for (size_t i = 0; i < od->n_l3dgw_ports; i++) {
^
../ovn/northd/ovn-northd.c:5139:18: note: shadowed declaration is here
for (int i = 0; i < od->nbr->n_nat; i++) {
^
../ovn/northd/ovn-northd.c:5414:38: error: declaration of ‘l3dgw_port’
shadows a previous local [-Werror=shadow]
struct ovn_port *l3dgw_port = od->l3dgw_ports[i];
^~~~~~~~~~
../ovn/northd/ovn-northd.c:5197:30: note: shadowed declaration is here
struct ovn_port *l3dgw_port = find_l3dgw_port(od,
*********
Thanks
Numan
Thanks for review, Numan. I send v4.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
