On 21.03.2018 18:37, Ben Pfaff wrote: > On Wed, Mar 21, 2018 at 06:25:11PM +0300, Ilya Maximets wrote: >> DPDK could produce huge amount of logs. For example, in case of >> exhausting of a mempool in vhost-user port, following message will be >> printed on each call to 'rte_vhost_dequeue_burst()': >> >> |ERR|VHOST_DATA: Failed to allocate memory for mbuf. >> >> These messages are increasing ovs-vswitchd.log size extremely fast >> making it unreadable and non-parsable by a common linux utils like >> grep, less etc. Moreover continuously growing log could exhaust the >> HDD space in a few hours breaking normal operation of the whole system. >> >> To avoid such issues, DPDK log rate limited to 600 messages per minute. >> This value is high, because we still want to see many big logs like >> vhost-user configuration sequence or debug messages, if debug enabled >> in DPDK. >> >> Signed-off-by: Ilya Maximets <[email protected]> > > Would it make sense to rate-limit each log level separately, so that a > flood of DBG messages can't starve out ERR messages?
Hmm. Good point. I don't think that we need to have separate rl for each level, but it could be useful to handle "debug" level apart of other logs. I'll send v2 with that change. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
