Sounds like a job for VLOG_WARN ?
> -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Stokes, Ian > Sent: Thursday, March 22, 2018 2:52 PM > To: Kevin Traynor <[email protected]>; [email protected] > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Remove 'error' from non error log. > > > Presently, if OVS tries to setup more queues than are allowed by a > > specific NIC, OVS will handle this case by retrying with a lower > > amount of queues. > > > > Rather than reporting initial failed queue setups in the logs as > > ERROR, they are reported as INFO but contain the word 'error'. Unless > > a user has detailed knowledge of OVS-DPDK workings, this is confusing. > > > > Let's remove 'error' and the DPDK error code from the INFO log. > > > > Signed-off-by: Kevin Traynor <[email protected]> > > --- > > lib/netdev-dpdk.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index > > af9843a..2032712 > > 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@ -729,6 +729,6 @@ dpdk_eth_dev_queue_setup(struct netdev_dpdk *dev, > > int n_rxq, int n_txq) > > dev->socket_id, NULL); > > if (diag) { > > - VLOG_INFO("Interface %s txq(%d) setup error: %s", > > - dev->up.name, i, rte_strerror(-diag)); > > + VLOG_INFO("Interface %s unable to setup txq(%d)", > > + dev->up.name, i); > > I agree with removing error from the info message but is it worth retaining > the > DPDK error code for debugging somehwere? Maybe is a separate debug log? > > I'm just thinking are there other cases where the error code will help > decipher > why the operation fails (device busy, operation not supported) for tx and rx > queue setup? > > Ian > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
