The functions dp_packet_l4_checksum_valid() and dp_packet_l4_checksum_bad() seem similar. Should we also add "const" to them?
Acked-by: Justin Pettit <[email protected]> --Justin > On Feb 4, 2018, at 8:22 AM, Darrell Ball <[email protected]> wrote: > > Signed-off-by: Darrell Ball <[email protected]> > --- > lib/dp-packet.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/dp-packet.h b/lib/dp-packet.h > index b4b721c..61d4cd4 100644 > --- a/lib/dp-packet.h > +++ b/lib/dp-packet.h > @@ -637,7 +637,7 @@ dp_packet_mbuf_init(struct dp_packet *p OVS_UNUSED) > } > > static inline bool > -dp_packet_ip_checksum_valid(struct dp_packet *p OVS_UNUSED) > +dp_packet_ip_checksum_valid(const struct dp_packet *p OVS_UNUSED) > { > #ifdef DPDK_NETDEV > return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) == > @@ -648,7 +648,7 @@ dp_packet_ip_checksum_valid(struct dp_packet *p > OVS_UNUSED) > } > > static inline bool > -dp_packet_ip_checksum_bad(struct dp_packet *p OVS_UNUSED) > +dp_packet_ip_checksum_bad(const struct dp_packet *p OVS_UNUSED) > { > #ifdef DPDK_NETDEV > return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) == > -- > 1.9.1 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
