On 4/11/2018 11:13 AM, Ashish Varma wrote:
Sure, no problem.

Thanks,
Ashish

On Tue, Apr 10, 2018 at 5:00 PM, Gregory Rose <gvrose8...@gmail.com <mailto:gvrose8...@gmail.com>> wrote:

    On 4/6/2018 7:35 AM, Gregory Rose wrote:



        On 4/4/2018 10:23 AM, Ben Pfaff wrote:

            On Thu, Mar 29, 2018 at 04:46:09PM -0700, Ashish Varma wrote:

                Added test cases for encap, decap, replace and
                forwarding of NSH packets.
                Also added a python script 'sendpkt.py' to send hex
                ethernet frames.

                Signed-off-by: Ashish Varma <ashishvarma....@gmail.com
                <mailto:ashishvarma....@gmail.com>>

            Ashish, do you have a suggestion who should review this? 
            Greg, are you
            the right person?

        I can have a look at them now that I'm back but need to get
        caught up with some other issues first.


    Ashish,

    I continue to be otherwise occupied so I'm sorry for the delay in
    reviewing your patch.  It is still on my radar!

    Thanks,

    - Greg


Looks good - tests out alright to me:

set /bin/bash '../tests/system-kmod-testsuite' -C tests AUTOTEST_PATH='utilities:vswitchd:ovsdb:vtep:tests::/usr:ovn/controller-vtep:ovn/northd:ovn/utilities:ovn/controller' -k nsh -j1; \
"$@" || (test X'' = Xyes && "$@" --recheck)
## ------------------------------ ##
## openvswitch 2.9.90 test suite. ##
## ------------------------------ ##

nsh-datapath

 91: nsh - encap header                              ok
 92: nsh - decap header                              ok
 93: nsh - replace header                            ok
 94: nsh - forward                                   ok

## ------------- ##
## Test results. ##
## ------------- ##

All 4 tests were successful.

And the script code looks fine to me as well.

Tested-by: Greg Rose <gvrose8...@gmail.com>
Reviewed-by: Greg Rose <gvrose8...@gmail.com>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to