On Tue, Apr 17, 2018 at 12:29:12PM +0800, [email protected] wrote:
> From: wenxu <[email protected]>
>
> It makes OVS native tunneling honor tunnel-specified source addresses,
> in the same way that Linux kernel tunneling honors them.
>
> This patch made valid tun_src specified by flow-action can be used for
> tunnel_src of packet. add a "local" property for a route entry and enhance
> the priority of local route higher than user route.
> Like the kernel space when lookup the route, if there are tun_src specified
> by flow-action or port options. Check the tun_src wheather is a local
> address, then lookup the route.
>
> Signed-off-by: wenxu <[email protected]>
> Signed-off-by: frank.zeng <[email protected]>
Thanks a lot for this latest version.
This has patch conflicts due to a recent change in
ofproto/ofproto-dpif-sflow.c. Would you mind rebasing?
This code tends to use booleans in correct, but somewhat nonidiomatic
ways. For example:
if (p_src->local != true) {
would more idiomatically be written as:
if (!p_src->local) {
and:
if (rt->priority == rt->plen || rt->local == true) {
as:
if (rt->priority == rt->plen || rt->local) {
and:
if (rtm->rtm_type == RTN_LOCAL) {
change->rd.local = true;
} else {
change->rd.local = false;
}
as:
change->rd.local = rtm->rtm_type == RTN_LOCAL;
Would you mind adjusting the style?
I also noticed a doubled semicolon in sflow_choose_agent_address().
Thanks again,
Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
