On 26 April 2018 at 14:50, Simon Horman <[email protected]> wrote:
> Thanks Jianbo, > > On 26 April 2018 at 07:54, Jianbo Liu <[email protected]> wrote: > >> For tunnels, TOS ECN bits are never wildcard for the reason that they >> are always inherited. OVS will create a rewrite action if we add rule >> to modify other IP headers. But it also adds an extra ECN rewrite for >> the action because of this ECN un-wildcarding. >> >> It seems no error because the ECN bits to be changed are same in this >> case. But as rule can't be offloaded to hardware, the unnecssary ECN >> rewrite should be removed. >> >> Signed-off-by: Jianbo Liu <[email protected]> >> Reviewed-by: Paul Blakey <[email protected]> >> Reviewed-by: Roi Dayan <[email protected]> >> > > I'd like to take a little time to test this one. > Hi Jinbao, thanks again for your patch. We have tested this patch and from a functional point of view it looks good to me. Could you post a v2 which addresses the style concerns raised separately by Ben? Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
