> If the TLV map changed, then won't replacing 'tab' by the new one cause > the packet to be misinterpreted? If so, then it would be better to > detect the change and abort translating the packet. I don't think we > currently have a way to tell whether the TLV map changed, so we'd need > to add one. Thanks Ben for the review. I will investigate how to detect the TLV map change, and the side effect if we abort the packet translation.
> However, it's still better to avoid the crash, of course. I'd like to > see a comment update that mentions the reason we're replacing the table > pointer in this case though, and (if I'm right about the above) an XXX > comment that says that it would be better to abort translation if the > table changed. I added comment in v2. https://patchwork.ozlabs.org/patch/908130/ Thanks, -Yi-Hung _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
