On Mon, Apr 16, 2018 at 09:55:38PM -0700, aginwala wrote: > eval doesn't understand white space for local var which was introduced in > commit > 79c7961b8b3c4b7ea0251dea2ffacfa84c84fecb for starting clustered ovn dbs. > As ovn-ctl uses sh instead of bash, parsing local var with white space will > fail. > > e.g. /usr/share/openvswitch/scripts/ovn-ctl --db-nb-addr=192.168.220.101 > --db-nb-create-insecure-remote=yes \ > --db-sb-addr=192.168.220.101 --db-sb-create-insecure-remote=yes \ > --db-nb-cluster-local-addr=192.168.220.101 \ > --db-sb-cluster-local-addr=192.168.220.101 \ > > --ovn-northd-nb-db=tcp:192.168.220.101:6641,tcp:192.168.220.102:6641,tcp:192.168.220.103:6641 > \ > > --ovn-northd-sb-db=tcp:192.168.220.101:6642,tcp:192.168.220.102:6642,tcp:192.168.220.103:6642 > \ > start_northd > > gives error: /usr/share/openvswitch/scripts/ovn-ctl: 1: local: -vfile:info: > bad variable name > > As a result ovsdb fails to even initialize and start. Hence, we need to > seperate local keyword for all > variables used with eval to make it work with both dash and bash. > > Signed-off-by: aginwala <[email protected]>
Thanks, applied to master and branch-2.9. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
