On Tue, May 08, 2018 at 01:49:15PM -0700, Han Zhou wrote: > On Tue, May 8, 2018 at 1:10 PM, Ben Pfaff <[email protected]> wrote: > > > > On Sun, Apr 22, 2018 at 09:53:43AM -0700, Han Zhou wrote: > > > When clustering support is introduced, the naming convention of > > > environment variables OVN_NB_DB and OVN_SB_DB changed (something > > > like unix:nb1.ovsdb). This leads to all ovn-nbctl test cases and > > > many others fail when they are run in sandbox environment, because > > > in those test cases the naming convention of DBs are not changed. > > > > > > This patch fix the issue by setting the environment variables > > > properly in those test cases. > > > > > > Signed-off-by: Han Zhou <[email protected]> > > > > I'm not sure I understand. What do you mean by running these tests in > > the sandbox environment? The tests always run in their own dedicated > > environments that get spun up as necessary and destroyed immediately > > afterward. > > Sorry that if the title is misleading. It's better to be: make ovn tests > independent of environment. > > Normally we run tests with something like: make check TESTSUITEFLAGS="-k > ovn", and if the environment var is not set for OVN_NB_DB/OVN_SB_DB, it > will use the default, and the test cases will run without any issues. > > However, if those environment variable is set with values other than the > default ones, running those tests will fail. One typical scenario is when > someone like me happen to run the tests in sandbox environment, where > OVN_NB_DB/OVN_SB_DB is set different from the default ones.
Oh, I see, I understand now. I think it makes sense to just centrally clear these in one place before the tests start. What do you think of this proposal: https://patchwork.ozlabs.org/patch/911096/ Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
