On Fri, May 11, 2018 at 5:08 AM, Ben Pfaff <b...@ovn.org> wrote:
> On Thu, May 10, 2018 at 11:18:23PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique <nusid...@redhat.com>
> >
> > Presently when a VM's IPv6 stack sends a Neighbor Solicitation request
> for its
> > router IP, (mostly when the ND cache entry for the router is in STALE
> state)
> > ovn-controller responds with a Neighbor Adv packet (using the action
> nd_na).
> > But it doesn't set 'ND_RSO_ROUTER' in the RSO flags (please see RFC4861
> page 23).
> > Because of which, the VM deletes the default route. The default route
> gets added
> > again when the next RA is received (but would again gets deleted if its
> sends
> > NS request). And this results in disruption of IPv6 traffic.
> >
> > This patch addresses this issue by adding a new action 'nd_na_router'
> which is
> > same as 'nd_na' but it sets the 'ND_RSO_ROUTER' in the RSO flags.
> ovn-northd
> > uses this action. A new action is added instead of modifying the
> existing 'nd_na'
> > action. This is because
> > - We cannot set the RSO flags in the "nd_na { ..actions .. }"
> > - It would be ugly to have something like nd_na { router_flags,
> ...actions .. }
> >
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1567735
> > Signed-off-by: Numan Siddique <nusid...@redhat.com>
> > Acked-by: Mark Michelson <mmich...@redhat.com>
>
> Please document the new action in ovn/ovn-sb.xml.
>
> Otherwise this looks good to me, thank you!
>
Thanks for the review Ben. I have updated the patch. Request to apply this
patch to branch 2.9 as well.
Thanks
Numan
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
