On 5/17/2018 4:12 PM, Ben Pfaff wrote:
On Thu, May 17, 2018 at 02:15:21PM -0700, Greg Rose wrote:
In netdev_to_ovs_vport_type() it checks for netdev types matching
"gre" with a strstr().  This makes it match ip6gre as well and return
OVS_VPORT_TYPE_GRE, which is clearly wrong.

Move the usage of strstr() *after* all the exact matches with strcmp()
to avoid the problem permanently because when I added the ip6gre
type I ran into a very difficult to detect bug.

Signed-off-by: Greg Rose <gvrose8...@gmail.com>
I think it would be better to avoid strstr here entirely.  As far as I
can tell this is here because we used to have gre, ipsec_gre, gre64, and
ipsec_gre64 vport types, but now only gre is left.

So that's the history of that!

Thanks Ben,  it'll be fixed up in V2.

- Greg
dev mailing list

Reply via email to