On Fri, May 18, 2018 at 5:49 PM, Greg Rose <[email protected]> wrote:
> From: Xin Long <[email protected]>
>
> Upstream commit:
>     commit c122fda271717f4fc618e0a31e833941fd5f1efd
>     Author: Xin Long <[email protected]>
>     Date:   Sun Oct 1 22:00:55 2017 +0800
>
>     ip_gre: set tunnel hlen properly in erspan_tunnel_init
>
>     According to __gre_tunnel_init, tunnel->hlen should be set as the
>     headers' length between inner packet and outer iphdr.
>
>     It would be used especially to calculate a proper mtu when updating
>     mtu in tnl_update_pmtu. Now without setting it, a bigger mtu value
>     than expected would be updated, which hurts performance a lot.
>
>     This patch is to fix it by setting tunnel->hlen with:
>        tunnel->tun_hlen + tunnel->encap_hlen + sizeof(struct erspanhdr)
>
>     Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
>     Signed-off-by: Xin Long <[email protected]>
>     Signed-off-by: David S. Miller <[email protected]>
>
> Cc: Xin Long <[email protected]>
> Signed-off-by: Greg Rose <[email protected]>
> ---

LGTM.
Acked-by: William Tu <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to