On Fri, May 18, 2018 at 5:49 PM, Greg Rose <[email protected]> wrote: > In netdev_to_ovs_vport_type() it checks for netdev types matching > "gre" with a strstr(). This makes it match ip6gre as well and return > OVS_VPORT_TYPE_GRE, which is clearly wrong. > > Move the usage of strstr() *after* all the exact matches with strcmp() > to avoid the problem permanently because when I added the ip6gre > type I ran into a very difficult to detect bug. > > Cc: Ben Pfaff <[email protected]> > Signed-off-by: Greg Rose <[email protected]> > --- > > V2 - Removed strstr for gre completely as per Ben's feedback. > V3 - Fix mucked up V2 where strcmp was used instead of !strcmp > ---
LGTM Acked-by: William Tu <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
