> > OK, now I understand what's going on. This is only used to define the > format of the OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS attribute. Since it's not > a wire format at all, we don't need to use ovs_16aligned_be32 either, > and an "int" is fine too. > > Since erspan_metadata is part of the kernel ABI, which is exposed via > Netlink, it should normally be defined by including a kernel header > rather than in packets.h, which normally just defines wire formats for > things. Can we arrange for that to happen? >
But the kernel UAPI erspan.h defines both 'struct erspan_md2' and 'struct erspan_metadata'. If we choose to include from kernel, then the wire format 'strct erspan_md2' isn't defined using ovs_16aligned_be32. or should we generate an erspan.h using kernel UAPI erspan.h? something like: sed -f ./build-aux/extract-odp-netlink-h < datapath/linux/compat/include/linux/openvswitch.h > include/odp-netlink.h but generate include/erspan.h Thanks William _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
