On 5/29/2018 4:34 PM, William Tu wrote:
William,

we need the following incremental:

gvrose@ubuntu:~/prj/ovs-experimental/_build$ git diff
diff --git a/datapath/linux/compat/ip6_gre.c
b/datapath/linux/compat/ip6_gre.c
index 24e850a..94a031c 100644
--- a/datapath/linux/compat/ip6_gre.c
+++ b/datapath/linux/compat/ip6_gre.c
@@ -2588,7 +2588,7 @@ struct net_device *ip6erspan_fb_dev_create(struct net
*net, const char *name,
         t = netdev_priv(dev);
         t->parms.collect_md = true;

-       err = ip6gre_newlink(net, dev, tb, NULL);
+       err = ip6erspan_newlink(net, dev, tb, NULL);
Thanks. That's my mistake.
The upstream kernel code does not have ip6erspan_fb_dev_create.

Easy find once I'd ensured upstream Linux works - then it was just looking at what OVS does.

Thanks!

- Greg


Regards,
William

         if (err < 0) {
                 free_netdev(dev);
                 return ERR_PTR(err);

That fixes things up so that both ip6gre and ip6erspan can work together in
OVS as well as native Linux.

With this incremental added....

Reviewed-by: Greg Rose <[email protected]>
Tested-by: Greg Rose <[email protected]>


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to