A user reported a failure of test 2364 "vlog - RFC5424 facility - Python2" with an exit code that says that the test-unixctl process died from an uncaught exception. Unfortunately the exception didn't show up in the log. This commit should make the exception show up (it deletes some boilerplate we use in our Python-based daemons to make them restart themselves on failure, which isn't needed or appropriate for a test script).
Reported-by: Sanket Sudake <[email protected]> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046840.html Signed-off-by: Ben Pfaff <[email protected]> --- tests/test-unixctl.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/tests/test-unixctl.py b/tests/test-unixctl.py index 5de51d31ecfd..4fa27b09f82d 100644 --- a/tests/test-unixctl.py +++ b/tests/test-unixctl.py @@ -13,7 +13,6 @@ # limitations under the License. import argparse -import sys import ovs.daemon import ovs.unixctl @@ -88,11 +87,4 @@ def main(): if __name__ == '__main__': - try: - main() - except SystemExit: - # Let system.exit() calls complete normally - raise - except: - vlog.exception("traceback") - sys.exit(ovs.daemon.RESTART_EXIT_CODE) + main() -- 2.16.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
