Hi, I looked into the code and the logic seems good to me.
But reordering in dataplane also has performance implications especially considering non-TCP traffic. Also, the packets came to OvS may already been out-of-ordered. Could you provide some performance data points showing when all EMC hit and mix of EMC-hit and EMC-miss cases, and how is the throughput affected? Also maybe considering only do it for TCP traffic? Thanks Yipeng >-----Original Message----- >From: [email protected] [mailto:[email protected]] >On Behalf Of Vishal Deep Ajmera >Sent: Monday, June 18, 2018 8:49 AM >To: [email protected] >Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Avoid reordering of packets in a >batch with same megaflow > >Hi, > >Does anyone see any issue with the patch ? The intent of the patch is to fix >*reordering* of packets belonging to same megaflow. The >issue can be frequently reproduced by running iperf test (as an example) >between two VM's connected by an OVS netdev bridge with >NORMAL flow. Analyzing packets captured at server side VM using wire-shark >shows packets with PSH flag are reordered by OVS. > >Warm Regards, >Vishal Ajmera >_______________________________________________ >dev mailing list >[email protected] >https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
