Thanks a lot Han for the review. Just sent the v2 with the test fixed. I'll leave the hash index for a follow up as I'm short in time but if you want to edit my patch feel free to do it or send another one.
Thanks again for the Port Groups implementation! :) Cheers, Daniel On Wed, Jun 20, 2018 at 4:15 AM, Han Zhou <[email protected]> wrote: > > > On Tue, Jun 19, 2018 at 5:49 PM, Ben Pfaff <[email protected]> wrote: > > > > On Tue, Jun 19, 2018 at 05:27:20PM -0700, Han Zhou wrote: > > > All looks good to me except that the test case "ovn -- ACLs on Port > Groups" > > > is broken with this change. I think it is because conntrack is not > > > supported in the dummy datapath and so the stateful ACL would not work > in > > > the test suites, and it was passing just because of this bug. So, to > fix > > > the test case, you need below change: > > > > I would have guessed that conntrack works OK in the dummy datapath > > because dpif-netdev supports conntrack. > > Ah, I admit that I am ignorant on this. I need to study more on it to > understand why this test case doesn't work. Is there any > tool/documentation/example on how to debug the dummy datapath conntrack, > such as dumping the conntrack table entries? > > Thanks, > Han > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
