On 06/25/2018 04:08 PM, Aaron Conole wrote:
0-day Robot <[email protected]> writes:Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: == Checking a417a986243d ("ovn: Allow for automatic dynamic updates of IPAM") == WARNING: Line is 83 characters long (recommended limit is 79) #372 FILE: ovn/northd/ovn-northd.c:1337: if (!od->ipam_info.allocated_ipv4s && !od->ipam_info.ipv6_prefix_set) { Lines checked: 694, Warnings: 1, Errors: 0I'm thinking of turning off the line-length checks for the bot. They're usually not something I'd seriously object over (unless it's well over 100 characters and easily split or something). Thoughts?
I disagree. If our checkpatch utility will complain about something, then the bot should complain about the same things.
I appreciate being called out by the bot in this case because I clearly didn't run checkpatch before submitting my patch.
Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
