Re: [ovs-dev] [PATCH v1 06/14] dp-packet: Handle multi-seg mbufs in helper funcs.

[Eelco Chaudron]

On 28 Jun 2018, at 17:41, Tiago Lam wrote:

> Most helper functions in dp-packet assume that the data held by a
> dp_packet is contiguous, and perform operations such as pointer
> arithmetic under that assumption. However, with the introduction of
> multi-segment mbufs, where data is non-contiguous, such assumptions are
> no longer possible. Some examples of Such helper functions are
> dp_packet_tail(), dp_packet_tailroom(), dp_packet_end(),
> dp_packet_get_allocated() and dp_packet_at().
>
> Thus, instead of assuming contiguous data in dp_packet, they  now
> iterate over the (non-contiguous) data in mbufs to perform their
> calculations.
>
> Finally, dp_packet_use__() has also been modified to perform the
> initialisation of the packet (and setting the source) before continuing
> to set its size and data length, which now depends on the type of
> packet.
>
> Co-authored-by: Mark Kavanagh <mark.b.kavan...@intel.com>
>
> Signed-off-by: Mark Kavanagh <mark.b.kavan...@intel.com>
> Signed-off-by: Tiago Lam <tiago....@intel.com>

LGTM,

Acked-by: Eelco Chaudron <echau...@redhat.com>

<SNIP>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev