Thanks a lot Ben for promptly reviewing the patch. I agree with you that now there is no real users of in_group. I will delete this and post the next version of patch.
Thanks Keshav -----Original Message----- From: Ben Pfaff [mailto:[email protected]] Sent: Wednesday, July 04, 2018 12:10 AM To: Keshav Gupta <[email protected]> Cc: [email protected] Subject: Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: Fix packet_in reason for Table-miss rule On Tue, Jul 03, 2018 at 11:14:45PM +0530, Keshav Gupta wrote: > Currently in OvS if we hit "Table-miss" rules (associated with > Controller > action) then we send PACKET_IN message to controller with reason as > OFPR_NO_MATCH. > > “Table-miss” rule is one whose priority is 0 and its catch all rule. > > But if we hit same "Table-miss" rule after executing group entry we > will send the reason as OFPR_ACTION (for OF1.3 and below) and > OFPR_GROUP (for OF1.4 and above). > > This is because once we execute group entry we set ctx->in_group and > later when we hit the "Table-miss" rule, Since ctx->in_group is set > we send reason as OFPR_ACTION (for OF1.3) and OFPR_GROUP (for OF1.4 and > above). Thanks for the patch. It looks to me like it fixes a real problem. This patch removes all the real users of 'in_group'. Please delete 'in_group' as part of the patch. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
