On 7/5/2018 9:46 PM, Ben Pfaff wrote:
On Thu, Jul 05, 2018 at 09:37:16PM +0100, Ian Stokes wrote:
On 7/5/2018 9:21 PM, Ben Pfaff wrote:
On Thu, Jul 05, 2018 at 07:33:06PM +0100, Ian Stokes wrote:
On 7/2/2018 9:57 PM, Ben Pfaff wrote:
+1. "Soft freeze" of the master branch.
+
+   During the freeze, we ask committers to refrain from applying patches that
+   add new features unless those patches were already being publicly discussed
+   and reviewed before the freeze began.  Bug fixes are welcome at any time. > 
+

Would there ever be an exception here? I'm thinking if a patch is submitted
for an existing feature and the patch is deemed low risk (i.e. fairly simple
but useful). I'm aware we want to draw up a deadline and stick to it but in
the case like this should an exception be requested from a maintainer? Or do
we stick to hard deadline and only previously discussed patches allowed.

We do have a history of making exceptions.  The closer we get to the
release, the more motivation we need, in terms of high importance or low
risk, etc.x

Fully agree, I suppose I'm wondering do we need to explicitly state that it
is possible but needs to be specifically flagged, I raise it only as I had
the same question raised to myself today. Playing devils advocate I guess,
maybe the danger of mentioning the exception process is that it will be
ab(used) :).

I think the approached outlined sounds good however, applied and tested.
Acked unless there are any objections.

OK, what if I add a sentence to point 1, like this:

     1. "Soft freeze" of the master branch.

        During the freeze, we ask committers to refrain from applying patches 
that
        add new features unless those patches were already being publicly 
discussed
        and reviewed before the freeze began.  Bug fixes are welcome at any 
time.
        Please propose and discuss exceptions on ovs-dev.
I think that sounds fine.

Thanks
Ian
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to