On Thu, Jul 5, 2018 at 1:49 PM, Ian Stokes <[email protected]> wrote:
> On 7/5/2018 9:38 PM, Darrell Ball wrote: > >> Traditionally, for boolean variables we use boolean values. >> Lets keep to that tradition. >> Hopefully, using false with a bool works with gcc 6.3.1; >> I use both recent versions of gcc (7.3) and older >> versions (4.x), but did not see the issue found in >> 165c1f0649af commit. >> >> Cc: Ian Stokes<[email protected]> >> Fixes: 165c1f0649af ("db-ctl-base: Fix compilation warnings.") >> Signed-off-by: Darrell Ball <[email protected]> >> --- >> lib/db-ctl-base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c >> index 1768b45..4af8489 100644 >> --- a/lib/db-ctl-base.c >> +++ b/lib/db-ctl-base.c >> @@ -920,7 +920,7 @@ cmd_get(struct ctl_context *ctx) >> if (id) { >> struct ovsdb_symbol *symbol = NULL; >> - bool new = NULL; >> + bool new = false; >> ctx->error = create_symbol(ctx->symtab, id, &symbol, &new); >> if (ctx->error) { >> >> > Apologies Darrell, silly mistake on my part. Compiled and tested ok. > > Acked-by: Ian Stokes ([email protected]) > Thanks; no worries. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
