On Wed, Jun 6, 2018 at 10:05 PM, Justin Pettit <[email protected]> wrote:
> > > On Apr 8, 2018, at 7:54 PM, Darrell Ball <[email protected]> wrote: > > > > diff --git a/lib/dpctl.man b/lib/dpctl.man > > index 6223c15..43cff05 100644 > > --- a/lib/dpctl.man > > +++ b/lib/dpctl.man > > @@ -286,3 +286,11 @@ Sets the minimum fragment size supported by the > userspace datapath > > connection tracker. Either v4 or v6 must be specified. The default v4 > > value is 1200 and the clamped minimum is 400. The default v6 value is > > 1280, which is also the clamped minimum. > > +. > > +.TP > > +\*(DX\fBipf\-set\-maxfrags\fR [\fIdp\fR] \fBmaxfrags\fR > > +Sets the maximum number of fragments tracked by the userspace datapath > > +connection tracker. The default value is 1000 and the clamped maximum > > +is 5000. Note that packet buffers can be held by the fragmentation > > +module while fragments are incomplete, but will timeout after 15 > seconds. > > +Memory pool sizing should be set accordingly when fragmentation is > enabled. > > Once again, I think the internal name is a bit better than the > user-exposed one: ipf-set-nfrag-max. > I was trying to avoid the 4-part name, guessing people would not like it; I prefer the 4-part name myself, so we are in agreement, with minor difference. I prefer ipf-set-max-nfrags "max" is a bit better before "nfrag" or "nfrags" as it follows English sentence structure, where the adjective usually precedes the noun. > > Also, some of my previous comments for the other commands apply here, too. > got it; thanks. > > Thanks, > > --Justin > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
