On Sat, 28 Jul 2018 23:54:32 -0700 Han Zhou <zhou...@gmail.com> wrote:
> On Thu, Jul 26, 2018 at 3:51 AM, Jakub Sitnicki <j...@redhat.com> wrote: > > > > If a logical switch port belongs to a port group and has dynamic > > addresses assigned, propagate the addresses to the auto-generated > > address sets for the port group. > > > > Signed-off-by: Jakub Sitnicki <j...@redhat.com> > > --- (...) > Thanks for the fix! Just a minor problem: > > It would be better to check if the address is dynamic using > is_dynamic_lsp_address() before calling split_addresses(). Otherwise, there > seems to be annoying INFO log: "invalid syntax '%s' in address" printed if > the address is "dynamic". > > Acked-by: Han Zhou <hzh...@ebay.com> Thanks a lot for the review, Han. I've posted v2 with the suggested fix and kept your acks: https://patchwork.ozlabs.org/project/openvswitch/list/?series=58323 -Jakub _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev