Thanks for the review. I've separated them into two patches in v6. Martin
On Wed, Aug 1, 2018 at 3:48 PM, Yi-Hung Wei <[email protected]> wrote: > On Wed, Aug 1, 2018 at 2:26 PM, Martin Xu <[email protected]> wrote: > > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch > > build against multiple kernels, rhel6) to support building kmod RPMs > > with multiple minor revisions within 3.10.0-327 kernels. It was > > discovered for RHEL 7.2 that 41.3 minor revision introduced backward > > incompatible changes. > > > > Also fixes a scenario not working for RHEL7.3 in commit 89dd5819cf18. > > When multiple versions passed into the kversion for the spec file, the > > variable is used as is for the kernel module paths for command > > weak-modules --add-modules. Then the modules cannot be found. > > > > Fixes: 89dd5819cf18 (rhel: support kmod-openvswitch build against > > multiple kernels, rhel6) > > > > VMware-BZ: #2170334 > > > > Signed-off-by: Martin Xu <[email protected]> > > CC: Greg Rose <[email protected]> > > CC: Ben Pfaff <[email protected]> > > CC: Flavio Leitner <[email protected]> > > CC: Yi-Hung Wei <[email protected]> > > --- > > v1->v2: added author sign-off signature > > v2->v3: instead of using hard coded versions for openvswitch kernel > modules, > > retrieve the information from kmod package > > v3->v4: sent wrong v3 patch, some echo's for debugging not removed > > v4->v5: fix one line that exceeded 79 chars > > Thanks for the patch. I think it is much robust than the previous > version. I also did some tests on REHL 7.2 and it works great. > > One minor comment is that we generally separate bug fix and new > feature into two patches. It usually makes the commit to be more > clear. > > Acked-by: Yi-Hung Wei <[email protected]> > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
