Hi Ian/Ben , Please find my comments below.
Regards _Sugesh > -----Original Message----- > From: Stokes, Ian > Sent: Wednesday, August 1, 2018 3:24 PM > To: Ben Pfaff <[email protected]>; [email protected] > Cc: Chandran, Sugesh <[email protected]> > Subject: Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization. > > On 7/12/2018 10:55 PM, Ben Pfaff wrote: > > The macros are hard to read. This makes it a little more readable. > > > > Thanks for this Ben, one minor comment below. > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > > > -#define DPDK_FLOW_OFFLOAD_API \ > > - NULL, /* flow_flush */ \ > > - NULL, /* flow_dump_create */ \ > > - NULL, /* flow_dump_destroy */ \ > > - NULL, /* flow_dump_next */ \ > > - netdev_dpdk_flow_put, \ > > - NULL, /* flow_get */ \ > > - netdev_dpdk_flow_del, \ > > - NULL /* init_flow_api */ > > Not sure if DPDK_FLOW_OFFLOAD_API should be completely removed, as I > understand it the remaining offload functionality is currently being > worked on with a view to enable full HW offload so they will be > re-introduced in the future. > > The macro could be moved from here to netdev-dpdk.h and then added to > the NETDEV_DPDK_CLASS_BASE macro you introduce below (this would be > similar to what is implemented for netdev-linux, and a more uniform > approach across the netdevs). > > Sugesh, you've been involved in the HW full offload work, do you have an > opinion on this? > > Ian [Sugesh] I agree with Ian here, We are looking at full offload solutions in DPDK Datapath which need to use the remaining flow related APIs for the flow management in the hardware. So I think it make sense to keep it uniform across different netdevs. > > - > > - > > -#define NETDEV_DPDK_CLASS(NAME, INIT, CONSTRUCT, DESTRUCT, \ > > - SET_CONFIG, SET_TX_MULTIQ, SEND, \ > > - GET_CARRIER, GET_STATS, \ > > - GET_CUSTOM_STATS, > > \ > > - GET_FEATURES, GET_STATUS, \ > > - RECONFIGURE, RXQ_RECV) \ > > -{ \ _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
