> Signed-off-by: Ben Pfaff <[email protected]> > --- <-----------------------B<----------------------> > if (error) { > - ovs_error(error, "could not initialize control socket %s", punix_path); [Alin Serdean] Changing the log message will make the following test fail: 130. daemon.at:148: testing daemon --detach startup errors ... ./daemon.at:150: ovsdb-tool create db $abs_top_srcdir/vswitchd/vswitch.ovsschema stderr: stdout: ./daemon.at:150: ovsdb-tool transact db \ '["Open_vSwitch", {"op": "insert", "table": "Open_vSwitch", "row": {}}]' stderr: stdout: [{"uuid":["uuid","017d6f26-bd86-40bf-8886-230ea05c26a0"]}] ./daemon.at:151: ovsdb-server --detach --no-chdir --pidfile --unixctl=nonexistent/unixctl db stderr: 2018-08-03T14:04:58Z|00001|fatal_signal|WARN|could not unlink "/home/ubuntu/ovs/tests/testsuite.dir/0130/nonexistent/unixctl" (No such file or directory) 2018-08-03T14:04:58Z|00002|stream_unix|ERR|/home/ubuntu/ovs/tests/testsuite. dir/0130/nonexistent/unixctl: binding failed: No such file or directory ovsdb-server: /home/ubuntu/ovs/tests/testsuite.dir/0130/nonexistent/unixctl: could not initialize control socket (No such file or directory) ./daemon.at:152: grep 'ovsdb-server: could not initialize control socket' stderr stdout: ./daemon.at:152: exit code was 1, expected 0 pid: sed: can't read pid: No such file or directory 130. daemon.at:148: FAILED (daemon.at:152) > - goto exit; > + ovs_error(error, "%s: could not initialize control socket", abs_path); > + free(abs_path); > + return error; > } > <-----------------------B<---------------------->
Acked-by: Alin Gabriel Serdean <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
