On Thu, Aug 02, 2018 at 08:20:58PM -0700, Darrell Ball wrote:
> The function dpctl_flush_conntrack() and other such functions with
> multiple optional arguments can be simplified by introducing a new
> function to check whether a valid datapath name is supplied as an
> argument to the functions.
> 
> opt_dpif_open() can also make use of this new function to allow it
> to handle callers with multiple optional arguments.
> 
> Signed-off-by: Darrell Ball <dlu...@gmail.com>

Thanks for working on making the OVS code easier to understand.

When I applied this patch, I get two test failures:

1195: ofproto-dpif - ovs-appctl dpif/get-flow         FAILED 
(ofproto-dpif.at:7838)
1196: ofproto-dpif - ovs-appctl dpif/get-flow - pmd   FAILED 
(ofproto-dpif.at:7839)

Can you take a look?

Thanks,

Ben.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to