On 04.08.2018 03:17, Ben Pfaff wrote: > On Wed, Aug 01, 2018 at 05:00:09PM +0300, Ilya Maximets wrote: >> Each run of the testsuite produces millions lines in a system >> log. This is completely unnecessary and makes it difficult to >> use system logs on test / build servers. >> >> This series is aimed to disable most of the syslog messages. >> There are still few logs that requires significant changes in >> tests or code to disable. They will be removed separately if >> needed. > > This series seems technically high-quality. Thank you. > > I find myself wondering whether we should just introduce an environment > variable to allowing configuring logging defaults. Then we would cover > literally everything with a single line in atlocal.in. > > Any opinions?
I thought about this. And implementation will have few issues: 1. Many daemons already has logging related options in cmdlines. This means that it should not be "OVS_DEFAULT_LOGGING_OPTIONS", but "OVS_FORCE_LOGGING_OPTIONS". i.e. the value in the environment should have highest priority. 2. Leads from the 1st. I'm not sure that we should expose variables like this for the end users, because there will be no way to change the logging level for the targets forced by the environment. So, it should be test only variable like "TEST_OVS_FORCE_DEFAULT_OPTIONS". But we still can't be sure that no one will use it in production. 3. Some tests (like some from vlog.at) requires ability to change the log level for syslog, for example. We'll need to unset the variable for these tests or change the tests themselves. 4. Modifications for all the utils/daemons and/or the vlog subsystem are required to implement this environment variable which is intended for test purposes only I'm not sure which solution is better. What do you think? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
