On Mon, Aug 06, 2018 at 02:06:09PM -0700, Ashish Varma wrote: > Added test for snoop command to check for the initial handshake messages > when a bridge connects to a controller via 'unix' connection method. > > Signed-off-by: Ashish Varma <[email protected]> > --- > v1-v2: > > Removed the sleep and added OVS_WAIT_UNTIL. > Added comment on why we are adding an exception for the 'connection failed' > WARN log message. > Added '-vsyslog:off'. > Minor change for pid file name change.
Thanks for the patch! It's great to improve test coverage. It's a little unusual to write "1>file" in shell. Usually one just writes ">file". It's a little better to move the on_exit "kill" command before the command that starts the process. That way, there is no race between starting the process and registering to have it killed on interrupt. I don't know of a reason to delete snoopbr0.txt when the test exits. If there is no reason, it is better to leave it, because on failure it allows the developer to examine it to figure out the reason for the failure. Even if it should be deleted, I don't know why the "unlink" program would be used (I had to look it up to make sure it really exists). I do not think that it is portable. "rm" is available everywhere. Thanks! Ben _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
