On Mon, Aug 06, 2018 at 03:55:55PM -0700, Darrell Ball wrote:
> By making opt_dpif_open() more general, it can be used effectively
> by all potential callers. Also, the error handling is improved by
> having more specific errors.
> 
> Signed-off-by: Darrell Ball <[email protected]>

I'm not sure I understand the improvement yet.  It looks to me like this
only provides value if the user specifies a dp name that contains @.
I'm not sure that's something that is commonly done; I only do it in
extremis.

It looks like the algorithm enumerates all the datapaths and opens them
in turn and then checks whether the name is what the user asked for.  Is
this better than just trying to open what the user asked for and seeing
if it worked?

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to